[Bug #21669] Void value expressions #3728
Draft
+674
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
void-value-expression
branch
4 times, most recently
from
c13c3da to
e99cda8
Compare
kddnewton
approved these changes
Nov 23, 2025
See https://bugs.ruby-lang.org/issues/21669#note-4 > At line 1067, void_node = vn is executed (and vn is guaranteed to be non-NULL on the line above), so it's impossible for void_node to be NULL at line 1075. Thus, it is indeed dead code.
…4ba56e3e21892a4cd0c
Earlopain
force-pushed
the
void-value-expression
branch
from
e99cda8 to
779470a
Compare
Collaborator
|
Where are we with this? Did nobu's upstream changes get merged? |
Collaborator
Author
|
(PR ref ruby/ruby#15498) Not merged, no. He fixed a case I forgot to implement (ruby/ruby@74ea62b) but in some edge case prism doesn't emit unused variable warnings anymore. I haven't looked into it though. Should I just continue in this PR here, or? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For [Bug #21669]